Master volume added #2149
Closed
Master volume added #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 5, 2017 11:26
Fourdee
added a commit
to MichaIng/DietPi
that referenced
this pull request
Aug 5, 2017
+ General | RPi: Kernel updated to 4.9.40. Includes improved driver support for Allo Piano and DiGi One: raspberrypi/linux#2149
|
Although I appreciate the improved adherence to the kernel coding style, try not to mix cosmetic changes (unless very small or non-overlapping) with functional changes - they obscure the real differences. I'd prefer them as separate commits for review, even if they get squashed when merged. |
pelwell
reviewed
Aug 6, 2017
sound/soc/bcm/allo-piano-dac-plus.c
Outdated
| if (val < 0) | ||
| return val; | ||
|
|
||
| ucontrol->value.integer.value[0] = (val & 0x10) ? 0 : 1; |
There was a problem hiding this comment.
A few more named constants, such as a name for bit 4 of PCM512x_MUTE, would make your code easier to understand.
|
Thanks Pelwell, noted. |
pelwell
pushed a commit
that referenced
this pull request
Aug 8, 2017
Master volume added, which controls both DACs volumes. See: #2149
pelwell
pushed a commit
that referenced
this pull request
Aug 8, 2017
|
Merged manually. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Aug 8, 2017
kernel: allo-digione: 192kHz clicking sound fix kernel: allo-piano-dac-plus: Master volume added See: raspberrypi/linux#2149 kernel: allo-piano-dac: Bug fix: unmuted See: raspberrypi/linux#2135
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Aug 8, 2017
kernel: allo-digione: 192kHz clicking sound fix kernel: allo-piano-dac-plus: Master volume added See: raspberrypi/linux#2149 kernel: allo-piano-dac: Bug fix: unmuted See: raspberrypi/linux#2135
popcornmix
pushed a commit
that referenced
this pull request
Aug 10, 2017
popcornmix
pushed a commit
that referenced
this pull request
Aug 10, 2017
Master volume added, which controls both DACs volumes. See: #2149
popcornmix
pushed a commit
that referenced
this pull request
Aug 13, 2017
popcornmix
pushed a commit
that referenced
this pull request
Aug 13, 2017
Master volume added, which controls both DACs volumes. See: #2149
Merged
Fourdee
added a commit
to MichaIng/DietPi
that referenced
this pull request
Sep 2, 2017
v155 (02/09/17) **New Image:** Rock64 | Now available for beta testing: https://github.com/Fourdee/DietPi/issues/1102#issuecomment-325131437 **Changes / Improvements / Optimizations:** General | RPi: Kernel updated to 4.9.40. Includes improved driver support for Allo Piano and DiGi One: raspberrypi/linux#2149 General | dietpi.txt: Added an dev option to force a resize + expansion on rootfs partition for next boot (fs_force_resize=1) General | RT kernel for RPi is now available, can be installed with "/DietPi/dietpi/func/dietpi-set_hardware kernel dietpi_rpi_rt" General | Reworked the disabled modules for Sparky. Disables touchscreen and GPU modules (thanks @sudeep). General | Sparky Image updated to Stretch, includes kernel update for DSD256/512 support. DietPi-Config | Networking > WiFi: Added a feature which will monitor the Wifi connection and automatically reconnect, if the gateway is unavailable (eg: connection drop): https://github.com/Fourdee/DietPi/issues/1074 DietPi-Software | Home Assistant: Now available for installation. Many thanks to @sytone for adding this: https://github.com/Fourdee/DietPi/pull/1087 DietPi-Software | Sabnzbd: Updated to 2.1.0 for new installations only: https://github.com/Fourdee/DietPi/issues/865#issuecomment-319110395 DietPi-Software | Kodi: Now installs avahi-daemon by default: http://dietpi.com/phpbb/viewtopic.php?f=11&t=2148&p=8323#p8316 DietPi-Software | sabnzbd: Updated to latest version (2.2.1), existing installations will need to uninstall/reinstall to update: https://github.com/Fourdee/DietPi/issues/865#issuecomment-325454351 **Bug fixes:** General | Auto Swapfile generation: Size is now set to "2048 - total memory" to prevent out of memory errors during Koel installations and in general. "1024 - total RAM" was previous. All systems will have swapfile regenerated during this patch, you can change this afterwards in dietpi-config > advanced options: https://github.com/Fourdee/DietPi/issues/1126 General | (Odroid C2): Resolved an issue where APT would fail to continue, due to deb-multimedia removing ARMv8 (ARM64) packages: https://github.com/Fourdee/DietPi/issues/1096 General | Fix error log on disabled IPv6 (thanks @MichaIng): https://github.com/Fourdee/DietPi/pull/1120/ DietPi-AutoStart | Resolved an issue where OPi devices would fail to execute selected autostart option: https://github.com/Fourdee/DietPi/issues/1109 DietPi-BugReport | Increased max upload size from 50MB to 80MB: https://github.com/Fourdee/DietPi/issues/1086#issuecomment-317724186 DietPi-Config | Corrected firmware upgrade code for OrangePi devices: http://dietpi.com/phpbb/viewtopic.php?f=11&t=2149&p=8295#p8295 DietPi-Software | Mumble/MurMur: Resolved an issue where superuser password was not being set during installation: http://dietpi.com/phpbb/viewtopic.php?f=11&t=2024#p8084 DietPi-Software | Tondio: Resolved an issue where the installation would fail due to lack of libjpeg8 packages, on Debian repos. Packages now hosted on dietpi.com: https://github.com/Fourdee/DietPi/issues/1101 DietPi-Software | Sparky SBC: WiFi Hotspot now triggers the RTL driver during install. This is hard coded, to configure for the official Allo WiFi dongle. DietPi-Software | Mopidy: Resolved an issue where the libary would fail to update. Many thanks to Sciamano: http://dietpi.com/phpbb/viewtopic.php?f=11&t=2112 DietPi-Software | Emby: Resolved an issue where unavailable libjpeg8 packages from Jessie/Stretch, would cause this installation to fail: https://github.com/Fourdee/DietPi/issues/1128#issuecomment-326743471
popcornmix
pushed a commit
that referenced
this pull request
Oct 29, 2017
popcornmix
pushed a commit
that referenced
this pull request
Oct 29, 2017
Master volume added, which controls both DACs volumes. See: #2149
raspbian-autopush
pushed a commit
to raspbian-packages/linux-4.9
that referenced
this pull request
Nov 2, 2017
commit 85dde07 Author: allocom <[email protected]> Date: Sat Aug 5 11:26:47 2017 +0530 allo-piano-dac-plus: Master volume added Master volume added, which controls both DACs volumes. See: raspberrypi/linux#2149 Gbp-Pq: Topic rpi Gbp-Pq: Name rpi_1332_85dde07a401816eba0b3c507fce88bc8c95aa405.patch
raspbian-autopush
pushed a commit
to raspbian-packages/linux-4.9
that referenced
this pull request
Nov 2, 2017
commit dcf5b3a Author: allocom <[email protected]> Date: Sat Aug 5 11:27:07 2017 +0530 allo-digione: 192kHz clicking sound fix See: raspberrypi/linux#2149 Gbp-Pq: Topic rpi Gbp-Pq: Name rpi_1333_dcf5b3af7aaeb7be2bdd19187add95a7466ede1f.patch
pelwell
pushed a commit
to pelwell/linux
that referenced
this pull request
Nov 18, 2017
Master volume added, which controls both DACs volumes. See: raspberrypi#2149
pelwell
pushed a commit
to pelwell/linux
that referenced
this pull request
Nov 18, 2017
pelwell
pushed a commit
to pelwell/linux
that referenced
this pull request
Nov 19, 2017
Master volume added, which controls both DACs volumes. See: raspberrypi#2149
pelwell
pushed a commit
to pelwell/linux
that referenced
this pull request
Nov 19, 2017
pelwell
pushed a commit
to pelwell/linux
that referenced
this pull request
Nov 19, 2017
Master volume added, which controls both DACs volumes. See: raspberrypi#2149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On allo-piano-dac-plus.c: Master volume added, which controls both DACs volume.
On allo-digione.c: 192kHz sampling rate clicking sound fix.